refactor: type fixes and some light housekeeping #528
Merged
+112
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
callmehiphop
added
the
do not merge
| @@ -233,14 +233,5 @@ describe('Snapshot', () => { | |||
|
|
|||
| snapshot.delete(done); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
So... what's up with the deleted test?
There was a problem hiding this comment.
They were useless. We would do a callback = callback || noop but callback will never be undefined because omitting it just uses the promisified version.
JustinBeckwith
approved these changes
Mar 6, 2019
|
LGTM, assuming tests pass :) |
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 94.95% 94.78% -0.18%
==========================================
Files 16 16
Lines 992 959 -33
Branches 87 84 -3
==========================================
- Hits 942 909 -33
Misses 42 42
Partials 8 8
Continue to review full report at Codecov.
|
callmehiphop
removed
the
do not merge
yoshi-automation
added a commit
that referenced
this pull request
May 8, 2020
Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Wed May 6 13:16:18 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: be74d3e532faa47eb59f1a0eaebde0860d1d8ab4 Source-Link: googleapis/synthtool@be74d3e
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 8, 2020
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
…pis#727) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
Fixes #526
Closes #525